fix lint warnings

lib/buffer/reflow_strategy.dart

@@ -1,6 +1,4 @@
 import 'package:xterm/buffer/buffer.dart';
-import 'package:xterm/buffer/line/line.dart';
-import 'package:xterm/util/circular_list.dart';
 
 abstract class ReflowStrategy {
   final Buffer _buffer;

lib/buffer/reflow_strategy_narrower.dart

@@ -1,4 +1,3 @@
-import 'dart:math';
 
 import 'package:xterm/buffer/buffer.dart';
 import 'package:xterm/buffer/line/line.dart';

lib/frontend/input_behavior.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/services.dart';
-import 'package:flutter/widgets.dart';
 import 'package:xterm/xterm.dart';
 
 abstract class InputBehavior {

lib/frontend/input_behavior_default.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/services.dart';
-import 'package:flutter/widgets.dart';
 import 'package:xterm/frontend/input_behavior.dart';
 import 'package:xterm/frontend/input_map.dart';
 import 'package:xterm/xterm.dart';
@@ -33,7 +32,7 @@ class InputBehaviorDefault extends InputBehavior {
     }
   }
 
-  String? _composingString = null;
+  String? _composingString;
 
   TextEditingValue? _lastEditingState;
 

lib/frontend/input_behavior_mobile.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/services.dart';
-import 'package:flutter/widgets.dart';
 import 'package:xterm/frontend/input_behavior_default.dart';
 import 'package:xterm/input/keys.dart';
 import 'package:xterm/xterm.dart';

lib/frontend/terminal_painters.dart

@@ -1,7 +1,6 @@
 import 'dart:math';
 
 import 'package:flutter/material.dart';
-import 'package:flutter/widgets.dart';
 import 'package:xterm/buffer/cell_flags.dart';
 import 'package:xterm/buffer/line/line.dart';
 import 'package:xterm/mouse/position.dart';

lib/frontend/terminal_view.dart

@@ -1,12 +1,9 @@
 import 'dart:math' as math;
-import 'dart:ui';
 
 import 'package:flutter/cupertino.dart';
 import 'package:flutter/gestures.dart';
 import 'package:flutter/material.dart';
-import 'package:flutter/rendering.dart';
 import 'package:flutter/scheduler.dart';
-import 'package:flutter/services.dart';
 import 'package:xterm/frontend/cache.dart';
 import 'package:xterm/frontend/char_size.dart';
 import 'package:xterm/frontend/helpers.dart';

lib/terminal/csi.dart

@@ -1,5 +1,4 @@
 import 'dart:collection';
-import 'dart:convert';
 
 import 'package:xterm/terminal/modes.dart';
 import 'package:xterm/terminal/sgr.dart';

lib/terminal/terminal.dart

@@ -757,7 +757,7 @@ class Terminal
   int? get currentSearchHit => _userSearchTask.currentSearchHit;
 
   @override
-  void set currentSearchHit(int? currentSearchHit) {
+  set currentSearchHit(int? currentSearchHit) {
     _userSearchTask.currentSearchHit = currentSearchHit;
     _scrollCurrentHitIntoView();
     refresh();
@@ -767,7 +767,7 @@ class Terminal
   TerminalSearchOptions get userSearchOptions => _userSearchTask.options;
 
   @override
-  void set userSearchOptions(TerminalSearchOptions options) {
+  set userSearchOptions(TerminalSearchOptions options) {
     _userSearchTask.options = options;
     _scrollCurrentHitIntoView();
     refresh();
@@ -777,7 +777,7 @@ class Terminal
   String? get userSearchPattern => _userSearchTask.pattern;
 
   @override
-  void set userSearchPattern(String? newValue) {
+  set userSearchPattern(String? newValue) {
     _userSearchTask.pattern = newValue;
     _scrollCurrentHitIntoView();
     refresh();
@@ -787,7 +787,7 @@ class Terminal
   bool get isUserSearchActive => _userSearchTask.isActive;
 
   @override
-  void set isUserSearchActive(bool isUserSearchActive) {
+  set isUserSearchActive(bool isUserSearchActive) {
     _userSearchTask.isActive = isUserSearchActive;
     _scrollCurrentHitIntoView();
     refresh();

lib/terminal/terminal_isolate.dart

@@ -623,7 +623,7 @@ class TerminalIsolate with Observable implements TerminalUiInteraction {
   }
 
   @override
-  void set currentSearchHit(int? currentSearchHit) {
+  set currentSearchHit(int? currentSearchHit) {
     _sendPort?.send([_IsolateCommand.updateCurrentSearchHit, currentSearchHit]);
   }
 
@@ -632,7 +632,7 @@ class TerminalIsolate with Observable implements TerminalUiInteraction {
       _lastState?.userSearchOptions ?? TerminalSearchOptions();
 
   @override
-  void set userSearchOptions(TerminalSearchOptions options) {
+  set userSearchOptions(TerminalSearchOptions options) {
     _sendPort?.send([_IsolateCommand.updateSearchOptions, options]);
   }
 
@@ -642,7 +642,7 @@ class TerminalIsolate with Observable implements TerminalUiInteraction {
   }
 
   @override
-  void set userSearchPattern(String? newValue) {
+  set userSearchPattern(String? newValue) {
     _sendPort?.send([_IsolateCommand.updateSearchPattern, newValue]);
   }
 
@@ -652,7 +652,7 @@ class TerminalIsolate with Observable implements TerminalUiInteraction {
   }
 
   @override
-  void set isUserSearchActive(bool isUserSearchActive) {
+  set isUserSearchActive(bool isUserSearchActive) {
     _sendPort
         ?.send([_IsolateCommand.updateIsUserSearchActive, isUserSearchActive]);
   }

lib/terminal/terminal_search.dart

@@ -10,7 +10,7 @@ import 'package:xterm/util/unicode_v11.dart';
 /// the search results
 class TerminalSearchResult {
   late final _allHits;
-  int? _currentSearchHit = null;
+  int? _currentSearchHit;
 
   /// creates a new search result instance from the given hits
   TerminalSearchResult.fromHits(List<TerminalSearchHit> hits) {
@@ -34,7 +34,7 @@ class TerminalSearchResult {
   int? get currentSearchHit => _currentSearchHit;
 
   /// sets the current search hit number
-  void set currentSearchHit(int? currentSearchHit) {
+  set currentSearchHit(int? currentSearchHit) {
     if (_allHits.length <= 0) {
       _currentSearchHit = null;
     } else {
@@ -131,9 +131,9 @@ class TerminalSearchTask {
 
   final TerminalSearch _search;
   final TerminalSearchInteraction _terminal;
-  String? _pattern = null;
+  String? _pattern;
   bool _isPatternDirty = true;
-  RegExp? _searchRegexp = null;
+  RegExp? _searchRegexp;
   final String _dirtyTagName;
   TerminalSearchOptions _terminalSearchOptions;
 
@@ -143,7 +143,7 @@ class TerminalSearchTask {
   bool get isActive => _isActive;
 
   /// sets the active state of this search task
-  void set isActive(bool isActive) {
+  set isActive(bool isActive) {
     _isActive = isActive;
     if (isActive) {
       _invalidate();
@@ -151,7 +151,7 @@ class TerminalSearchTask {
   }
 
   bool? _hasBeenUsingAltBuffer;
-  TerminalSearchResult? _lastSearchResult = null;
+  TerminalSearchResult? _lastSearchResult;
 
   bool _isAnyLineDirty() {
     final bufferLength = _terminal.buffer.lines.length;
@@ -192,7 +192,7 @@ class TerminalSearchTask {
   String? get pattern => _pattern;
 
   /// sets the pattern to use for this search task
-  void set pattern(String? newPattern) {
+  set pattern(String? newPattern) {
     if (newPattern != _pattern) {
       _pattern = newPattern;
       _invalidate();
@@ -203,7 +203,7 @@ class TerminalSearchTask {
   TerminalSearchOptions get options => _terminalSearchOptions;
 
   /// sets the search options to use
-  void set options(TerminalSearchOptions newOptions) {
+  set options(TerminalSearchOptions newOptions) {
     if (_terminalSearchOptions == newOptions) {
       return;
     }
@@ -231,7 +231,7 @@ class TerminalSearchTask {
   int? get currentSearchHit => searchResult.currentSearchHit;
 
   /// sets the hit number that shall be selected
-  void set currentSearchHit(int? currentSearchHit) {
+  set currentSearchHit(int? currentSearchHit) {
     searchResult.currentSearchHit = currentSearchHit;
   }
 

lib/terminal/terminal_ui_interaction.dart

@@ -146,24 +146,24 @@ abstract class TerminalUiInteraction with Observable {
   int? get currentSearchHit;
 
   /// sets the current search hit (gets clamped to the valid bounds)
-  void set currentSearchHit(int? currentSearchHit);
+  set currentSearchHit(int? currentSearchHit);
 
   /// gets the current user search options
   TerminalSearchOptions get userSearchOptions;
 
   /// sets new user search options. This invalidates the cached search hits and
   /// will re-trigger a new search
-  void set userSearchOptions(TerminalSearchOptions options);
+  set userSearchOptions(TerminalSearchOptions options);
 
   /// the search pattern of a currently active search or [null]
   String? get userSearchPattern;
 
   /// sets the currently active search pattern
-  void set userSearchPattern(String? pattern);
+  set userSearchPattern(String? pattern);
 
   /// gets if a user search is active
   bool get isUserSearchActive;
 
   // sets the user search active state
-  void set isUserSearchActive(bool isUserSearchActive);
+  set isUserSearchActive(bool isUserSearchActive);
 }

test/frontend/input_test.mocks.dart

@@ -20,6 +20,7 @@ import 'package:xterm/theme/terminal_theme.dart' as _i2;
 // ignore_for_file: invalid_use_of_visible_for_testing_member
 // ignore_for_file: prefer_const_constructors
 // ignore_for_file: unnecessary_parenthesis
+// ignore_for_file: camel_case_types
 
 class _FakeTerminalTheme_0 extends _i1.Fake implements _i2.TerminalTheme {}
 

test/terminal/terminal_search_test.dart

@@ -294,7 +294,7 @@ class _TestFixture {
 
   int _terminalWidth;
   int get terminalWidth => _terminalWidth;
-  void set terminalWidth(int terminalWidth) {
+  set terminalWidth(int terminalWidth) {
     _terminalWidth = terminalWidth;
     when(terminalSearchInteractionMock.terminalWidth).thenReturn(terminalWidth);
   }

test/terminal/terminal_search_test.mocks.dart

@@ -20,6 +20,7 @@ import 'terminal_search_test.dart' as _i8;
 // ignore_for_file: invalid_use_of_visible_for_testing_member
 // ignore_for_file: prefer_const_constructors
 // ignore_for_file: unnecessary_parenthesis
+// ignore_for_file: camel_case_types
 
 class _FakeBuffer_0 extends _i1.Fake implements _i2.Buffer {}